CI: Major refactor, expanded coverage, and ~80% speedup (#2736)

* netbsd fail on error

- Group each BSD test in its own subshell. Without this, if an error
occurs, it exits, but we don't know "where" it failed
- added *usesh: true* to BSD for faster copying into the virtualbox VM

- Some test_suite_runners wheren't correctly printing. added
--no-terminal
- For testing I've changed *build-msvc* from Debug to RelWithDebInfo

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* separate runs

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* fix typo

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* Split msvc-debug into separate workflow

Run msvc-debug only on maintainer pushes, keep CI fast and still catches
errors.

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* Fix build and test errors on NetBSD

* Set proper sizes for various types used for threads
* Add num_cpu function
* Add sysctl constants
* Allow testproject to build on NetBSD
* Tweaks to the linker code so that it adds correct flags and finds dynamic linker on NetBSD

* bsd: force system linker test

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* system linker on openbsd

remove lld from netbsd

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* use cc linker in openbsd, and re-add lld for netbsd

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* openbsd: fixes

- implement num_cpu() for OPENBSD
- testproject: add openbsd
- linker.c: fix for openbsd
- bsd refactor main.yml and more fixes

* openbsd: fix for unit tests and test_suite_runner

openbsd now passes all tests except the 'dynlib-test' which yields
'relocation error' when running `cc test.c -L. -ladd -Wl,-rpath=.`

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* openbsd: guard/disable unit test test_ct_intlog2()

* build-msys2-clang: add all tests that build-msvc has

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* Fix Windows import library generation by adding /IMPLIB support and properly declaring static_lib_name()

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* build-msys2-mingw: add all tests that build-msvc has and enable it

configure CMake to link LLVM and LLD statically

* Revert "Revert windows"

This reverts commit 197f82d829.

* win-llvm 21.1.8

uses the RelWithDebInfo+Assertions

* refactor(CI): Centralize test logic and fix Docker execution

This commit refactors the GitHub Actions workflow to improve
maintainability and correct a flaw in the Docker build.

- Ensures Docker based tests run *inside* the generated container, not
on the host. This also fixes environment isolation and user permission
errors.
- Centralizes all common test steps (examples, libs, unit tests, etc)
into a single, auto-detecting Bash script: `scripts/tools/ci_tests.sh`.
- Centralize all release artifact packaging into a single
`scripts/tools/package_build.sh`
- fixes using correct paths for test_suite_runner when running on
windows under bash.

- This significantly reduces YAML duplication, making `main.yml` more
readable and easier to maintain.

This one supersedes pull/2677, and includes the fixes for:

- fix openbsd and netbsd
- added win-llvm 21.1.8 and fixed CMakeLists.txt
- added full unit-tests and suite for build-msys2-mingw and
build-msys2-clang

* macos: add/fix build for llvm (19,20,21)

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* ci: run tests in temp dir to avoid workspace pollution

Executes ci_tests.sh in a disposable temporary directory by copying
resources/ and test/ folders, preventing build artifacts from cluttering
the source tree.

This makes it easy to run `scripts/tools/ci_tests.sh` locally on any
platform.

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* add ilammy/msvc-dev-cmd@ and Ninja

we can simplify the windows runner and run everything in bash

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* windows: drain subprocess stderr before join to avoid test_suite_runner hang

* move last test to `ci_tests.sh`

thus completing the centralization of tests in `ci_tests.sh`

* Fix Windows CI cache

Updates the cache key to include hashes of CMakeLists.txt and the
workflow file.

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* `package_build.sh` runs in temp dir to avoid workspace pollution

- add cleanup

* nix: use `ci_tests.sh`

* remove annoying build-mac warnings

This now checks if package already installed trying to prevent
annoying warnings in the github ci:

Fixes:
```
build-mac (Release, 19)curl 8.17.0 is already installed and up-to-date.
To reinstall 8.17.0, run: brew reinstall curl
```

* refactor test_suite_runner

- less allocations, cleaner code, more maintainable.
- now can be killed and the temp dirs are correctly cleaned up, and the
output is correct.

* main.yml: bsd: change to using rsync, is twice as fast.

* default to `--wincrt=dynamic` when `--sanitize=address` on windows

Default to dynamic, as static ASan is removed in LLVM 21+ for Windows
https://github.com/llvm/llvm-project/pull/107899

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>

* Formatting (indent with tab, align with space). Fix K&R braces. Style: keep all cases multiline if one is.

---------

Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>
Co-authored-by: Christoffer Lerno <christoffer@aegik.com>
Co-authored-by: Alex Garrett <limit.ordinal17@gmail.com>

scripts/tools/package_build.sh

@@ -0,0 +1,74 @@
+#!/usr/bin/env bash
+# Usage: ./package_build.sh <c3c_path> <output_name> <format: tar|zip>
+
+if [ $# -lt 2 ]; then
+    echo "Usage: ./package_build.sh <path_to_c3c_binary> <output_name> <format: tar|zip>"
+    exit 1
+fi
+
+set -ex
+
+C3C_BIN="$(realpath "$1")"
+OUT_NAME="$2"
+FORMAT="$3"
+BUILD_DIR="$(dirname "$C3C_BIN")" # Assuming c3c is in build/ or bin/
+
+# Go to repo root
+SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+ROOT_DIR="$(dirname "$(dirname "$SCRIPT_DIR")")"
+cd "$ROOT_DIR" || exit 1
+
+echo ">>> Packaging $OUT_NAME.$FORMAT from $C3C_BIN"
+
+# Create temp directory
+WORK_DIR=$(mktemp -d 2>/dev/null || mktemp -d -t 'c3_package')
+echo ">>> Setting up packaging workspace in: $WORK_DIR"
+
+cleanup() {
+    echo ">>> Cleaning up..."
+    cd "$ROOT_DIR" || cd ..
+    rm -rf "$WORK_DIR"
+}
+trap cleanup EXIT
+
+mkdir -p "$WORK_DIR/c3"
+cd "$WORK_DIR" || exit 1
+
+# Copy common files
+cp -r "$ROOT_DIR/lib" c3/
+cp "$ROOT_DIR/README.md" c3/
+cp "$ROOT_DIR/releasenotes.md" c3/
+cp "$ROOT_DIR/msvc_build_libraries.py" c3/
+
+# Copy binaries
+cp "$C3C_BIN" c3/
+if [[ -f "$BUILD_DIR/c3c.pdb" ]]; then cp "$BUILD_DIR/c3c.pdb" c3/; fi
+
+if [[ -d "$BUILD_DIR/c3c_rt" ]]; then
+    echo "Found c3c_rt directory at $BUILD_DIR/c3c_rt"
+    cp -r "$BUILD_DIR/c3c_rt" c3/
+else
+    echo "Warning: c3c_rt not found in $BUILD_DIR"
+fi
+
+# Compress
+if [[ "$FORMAT" == "zip" ]]; then
+    if command -v zip &> /dev/null; then
+        # Standard Unix zip
+        zip -r "$OUT_NAME.zip" c3
+    elif command -v 7z &> /dev/null; then
+        # for Windows/7-Zip fallback
+        echo "Info: 'zip' command not found. Using '7z'..."
+        7z a -tzip "$OUT_NAME.zip" c3
+    else
+        echo "Error: Neither 'zip' nor '7z' found."
+        exit 1
+    fi
+    
+    mv "$OUT_NAME.zip" "$ROOT_DIR/"
+else
+    tar -czf "$OUT_NAME.tar.gz" c3
+    mv "$OUT_NAME.tar.gz" "$ROOT_DIR/"
+fi
+
+echo ">>> Package created: $OUT_NAME.$FORMAT"