shishantbiswas/c3c
1
1
Fork 0
mirror of https://github.com/c3lang/c3c.git synced 2026-02-27 12:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

- Early exit in macro call crashes codegen #2820

Browse Source
This commit is contained in:
Christoffer Lerno
2026-01-25 00:52:57 +01:00
parent 378b35265b
commit 0fdd6bdc81
5 changed files with 73 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/compiler/llvm_codegen.c
View File

@@ -735,6 +735,7 @@ void gencontext_print_llvm_ir(GenContext *context)
INLINE LLVMValueRef llvm_emit_alloca_internal(GenContext *c, LLVMTypeRef type, unsigned alignment, const char *name)
{
ASSERT(c->current_block);
ASSERT(LLVMGetTypeKind(type) != LLVMVoidTypeKind);
ASSERT(!llvm_is_global_eval(c));
ASSERT(alignment > 0);

9
src/compiler/llvm_codegen_expr.c
View File

@@ -1383,7 +1383,7 @@ void llvm_emit_ignored_expr(GenContext *c, Expr *expr)
llvm_emit_expr(c, &value, expr);
EMIT_EXPR_LOC(c, expr);
// We only optimize if there is no instruction the current block
if (!LLVMGetFirstInstruction(c->current_block))
if (c->current_block && !LLVMGetFirstInstruction(c->current_block))
{
llvm_prune_optional(c, discard_fail);
}
@@ -6011,6 +6011,11 @@ static void llvm_emit_call_expr(GenContext *c, BEValue *result_value, Expr *expr
llvm_emit_statement_chain(c, expr->call_expr.function_contracts);
}
if (!llvm_get_current_block_if_in_use(c))
{
llvm_value_set(result_value, NULL, type_void);
return;
}
// 1. Dynamic dispatch.
if (expr->call_expr.is_dynamic_dispatch)
{
@@ -6278,6 +6283,7 @@ static inline void llvm_emit_macro_block(GenContext *c, BEValue *be_value, Expr
BEValue value;
c->debug.block_stack = old_inline_location;
llvm_emit_expr(c, &value, init_expr);
if (!c->current_block) goto EARLY_EXIT;
if (!val->alignment) val->alignment = type_abi_alignment(val->type);
if (llvm_value_is_addr(&value) || val->var.is_written || val->var.is_addr || llvm_use_accurate_debug_info(c))
{
@@ -6297,6 +6303,7 @@ static inline void llvm_emit_macro_block(GenContext *c, BEValue *be_value, Expr
{
llvm_emit_unreachable(c);
}
EARLY_EXIT:
if (!c->current_block)
{
llvm_emit_block(c, llvm_basic_block_new(c, "after_macro"));