From 39d4a97e24daa8a0977126ef339f9dbcdd7f7bb9 Mon Sep 17 00:00:00 2001
From: Christoffer Lerno <christoffer@aegik.com>
Date: Tue, 8 Oct 2024 20:34:41 +0200
Subject: [PATCH] Fix broken sincos function.

---
 lib/std/math/math.c3 | 35 +++++++++++++++++++++++++++--------
 releasenotes.md      |  1 +
 2 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/lib/std/math/math.c3 b/lib/std/math/math.c3
index e3c7d45b9..203c314c1 100644
--- a/lib/std/math/math.c3
+++ b/lib/std/math/math.c3
@@ -159,18 +159,37 @@ macro atan2(x, y)
 
 /**
  * @require values::@is_int(x) || values::@is_float(x) "Expected an integer or floating point value"
- * @require (@typekind(y) == ARRAY || @typekind(y) == VECTOR) &&& y.len == 2
- * @require $assignable(x, $typeof(y[0]))
+ * @require @typekind(sinp) == POINTER "Expected sinp to be a pointer"
+ * @require values::@is_same_type(sinp, cosp) "Expected sinp and cosp to have the same type"
+ * @require $assignable(x, $typeof(*sinp)) "Expected x and sinp/cosp to have the same type"
  **/
-macro sincos(x, y)
+macro sincos_ref(x, sinp, cosp)
 {
-	$if @typeid(y[0]) == float.typeid:
-		return _sincosf(x, y);
+	$if @typeid(*sinp) == float.typeid:
+		return _sincosf(x, sinp, cosp);
 	$else
-		return _sincos(x, y);
+		return _sincos(x, sinp, cosp);
 	$endif
 }
 
+/**
+ * Return a vector with sin / cos of the given angle.
+ *
+ * @param x `the angle in radians`
+ * @require values::@is_int(x) || values::@is_float(x) "Expected an integer or floating point value"
+ **/
+macro sincos(x)
+{
+	$if @typeid(x) == float.typeid:
+		float[<2>] v @noinit;
+		_sincosf(x, &v[0], &v[1]);
+	$else
+		double[<2>] v @noinit;
+		_sincos(x, &v[0], &v[1]);
+	$endif
+	return v;
+}
+
 /**
  * @require values::@is_int(x) || values::@is_float(x) "Expected an integer or floating point value"
  **/
@@ -1008,8 +1027,8 @@ extern fn double _atan(double x) @extern("atan");
 extern fn float _atanf(float x) @extern("atanf");
 extern fn double _atan2(double, double) @extern("atan2");
 extern fn float _atan2f(float, float) @extern("atan2f");
-extern fn void _sincos(double, double*) @extern("sincos");
-extern fn void _sincosf(float, float*) @extern("sincosf");
+extern fn void _sincos(double, double*, double*) @extern("__sincos") @link("m");
+extern fn void _sincosf(float, float*, float*) @extern("__sincosf") @link("m");
 extern fn double _tan(double x) @extern("tan");
 extern fn float _tanf(float x) @extern("tanf");
 extern fn double _scalbn(double x, int n) @extern("scalbn");
diff --git a/releasenotes.md b/releasenotes.md
index 98de63b20..87f43738b 100644
--- a/releasenotes.md
+++ b/releasenotes.md
@@ -17,6 +17,7 @@
 - Segfault with passing a program with `-` using stdin.
 - Using no module with `-` would reject the program.
 - Unintended deref of pointers with methods caused regression with hash function.
+- Fix broken sincos function.
 
 ### Stdlib changes
 - Remove unintended print of `char[]` as String