shishantbiswas/c3c
1
1
Fork 0
mirror of https://github.com/c3lang/c3c.git synced 2026-02-27 20:11:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix alignment on all indirect. Fixed incorrect preferred alignment. Added mingw regression tests.

Browse Source
This commit is contained in:
Christoffer Lerno
2021-07-16 13:05:56 +02:00
parent 11842e5dfa
commit 45a3c8ae50
16 changed files with 814 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/compiler/llvm_codegen_expr.c
View File

@@ -2399,12 +2399,12 @@ void llvm_emit_parameter(GenContext *c, LLVMValueRef **args, ABIArgInfo *info, B
case ABI_ARG_INDIRECT:
{
// If we want we could optimize for structs by doing it by reference here.
unsigned alignment = info->indirect.realignment ?: type_abi_alignment(type);
assert(info->indirect.alignment == type_abi_alignment(type) || info->attributes.realign);
LLVMValueRef indirect = llvm_emit_alloca(c,
llvm_get_type(c, type),
alignment,
info->indirect.alignment,
"indirectarg");
llvm_store_bevalue_aligned(c, indirect, be_value, alignment);
llvm_store_bevalue_aligned(c, indirect, be_value, info->indirect.alignment);
vec_add(*args, indirect);
return;
}
@@ -2610,14 +2610,15 @@ void llvm_emit_call_expr(GenContext *c, BEValue *be_value, Expr *expr)
{
case ABI_ARG_INDIRECT:
// 6a. We can use the stored error var if there is no redirect.
if (signature->failable && c->error_var && type_abi_alignment(return_type) < ret_info->indirect.realignment)
if (signature->failable && c->error_var && ret_info->attributes.realign)
{
error_var = c->error_var;
vec_add(values, error_var);
break;
}
// 6b. Return true is indirect, in this case we allocate a local, using the desired alignment on the caller side.
AlignSize alignment = ret_info->indirect.realignment ? ret_info->indirect.realignment : type_abi_alignment(return_type);
assert(ret_info->attributes.realign || ret_info->indirect.alignment == type_abi_alignment(return_type));
AlignSize alignment = ret_info->indirect.alignment;
llvm_value_set_address_align(be_value, llvm_emit_alloca(c, llvm_get_type(c, return_type), alignment, "sretparam"), return_type, alignment);
// 6c. Add the pointer to the list of arguments.