From 737559d3f8ebf5ef5ea29b5f009351a38b88c241 Mon Sep 17 00:00:00 2001
From: Christoffer Lerno <christoffer@aegik.com>
Date: Mon, 6 Jan 2025 12:36:59 +0100
Subject: [PATCH] Fix typo, minor changes.

---
 src/build/build_options.c        |  2 +-
 src/compiler/expr.c              |  8 +++-----
 src/compiler/llvm_codegen_expr.c | 11 ++++-------
 3 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/src/build/build_options.c b/src/build/build_options.c
index 5e2b8ffab..f5a5aa382 100644
--- a/src/build/build_options.c
+++ b/src/build/build_options.c
@@ -175,7 +175,7 @@ static void usage(bool full)
 		PRINTF("  --winsdk <dir>             - Set the directory for Windows system library files for cross compilation.");
 		PRINTF("  --wincrt=<option>          - Windows CRT linking: none, static-debug, static, dynamic-debug (default if debug info enabled), dynamic (default).");
 		PRINTF("  --windef <file>            - Use Windows 'def' file for function exports instead of 'dllexport'.");
-		PRINTF("  --win-vs-dirs <dir>;<dir> - Override Windows VS detection.");
+		PRINTF("  --win-vs-dirs <dir>;<dir>  - Override Windows VS detection.");
 		PRINTF("");
 		PRINTF("  --macossdk <dir>           - Set the directory for the MacOS SDK for cross compilation.");
 		PRINTF("  --macos-min-version <ver>  - Set the minimum MacOS version to compile for.");
diff --git a/src/compiler/expr.c b/src/compiler/expr.c
index b724d2d73..22ac107c0 100644
--- a/src/compiler/expr.c
+++ b/src/compiler/expr.c
@@ -640,6 +640,8 @@ bool expr_is_pure(Expr *expr)
 	if (!expr) return true;
 	switch (expr->expr_kind)
 	{
+		case EXPR_CAST:
+			UNREACHABLE
 		case EXPR_BUILTIN:
 		case EXPR_BENCHMARK_HOOK:
 		case EXPR_TEST_HOOK:
@@ -703,10 +705,8 @@ bool expr_is_pure(Expr *expr)
 		case EXPR_LAST_FAULT:
 		case EXPR_MEMBER_GET:
 			return true;
-		case EXPR_VASPLAT:
-			return true;
 		case EXPR_BITASSIGN:
-			return false;
+		case EXPR_VASPLAT:
 		case EXPR_ANYSWITCH:
 			return false;
 		case EXPR_BINARY:
@@ -763,8 +763,6 @@ bool expr_is_pure(Expr *expr)
 		case EXPR_FORCE_UNWRAP:
 		case EXPR_SUBSCRIPT_ASSIGN:
 			return false;
-		case EXPR_CAST:
-			return exprid_is_pure(expr->cast_expr.expr);
 		case EXPR_EXPRESSION_LIST:
 		{
 			FOREACH(Expr *, e, expr->expression_list)
diff --git a/src/compiler/llvm_codegen_expr.c b/src/compiler/llvm_codegen_expr.c
index b025c0448..d056da6bb 100644
--- a/src/compiler/llvm_codegen_expr.c
+++ b/src/compiler/llvm_codegen_expr.c
@@ -7035,6 +7035,10 @@ void llvm_emit_expr(GenContext *c, BEValue *value, Expr *expr)
 		case EXPR_DESIGNATOR:
 		case EXPR_MEMBER_GET:
 		case EXPR_NAMED_ARGUMENT:
+		case EXPR_BUILTIN:
+		case EXPR_COMPOUND_LITERAL:
+		case EXPR_OPERATOR_CHARS:
+		case EXPR_CAST:
 			UNREACHABLE
 		case EXPR_VECTOR_TO_ARRAY:
 			llvm_emit_vector_to_array(c, value, expr);
@@ -7162,8 +7166,6 @@ void llvm_emit_expr(GenContext *c, BEValue *value, Expr *expr)
 		case EXPR_TYPEID_INFO:
 			llvm_emit_typeid_info(c, value, expr);
 			return;
-		case EXPR_BUILTIN:
-			UNREACHABLE;
 		case EXPR_DECL:
 			llvm_emit_local_decl(c, expr->decl_expr, value);
 			return;
@@ -7188,9 +7190,6 @@ void llvm_emit_expr(GenContext *c, BEValue *value, Expr *expr)
 		case EXPR_EXPR_BLOCK:
 			llvm_emit_expr_block(c, value, expr);
 			return;
-		case EXPR_COMPOUND_LITERAL:
-		case EXPR_OPERATOR_CHARS:
-			UNREACHABLE
 		case EXPR_INITIALIZER_LIST:
 		case EXPR_DESIGNATED_INITIALIZER_LIST:
 			llvm_emit_initializer_list_expr(c, value, expr);
@@ -7248,8 +7247,6 @@ void llvm_emit_expr(GenContext *c, BEValue *value, Expr *expr)
 		case EXPR_EXPRESSION_LIST:
 			llvm_emit_expression_list_expr(c, value, expr);
 			return;
-		case EXPR_CAST:
-			UNREACHABLE
 		case EXPR_BITACCESS:
 			llvm_emit_bitaccess(c, value, expr);
 			return;