shishantbiswas/c3c
1
1
Fork 0
mirror of https://github.com/c3lang/c3c.git synced 2026-02-27 12:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix of evaluation order warning.

Browse Source
This commit is contained in:
Christoffer Lerno
2026-01-30 13:10:54 +01:00
parent cb19c7d9e7
commit 2b6f1c061d
4 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/std/core/types.c3
View File

@@ -329,8 +329,8 @@ macro lower_to_atomic_compatible_type($Type) @const
$endswitch
}
macro bool is_promotable_to_floatlike($Type) @const => types::is_floatlike($Type) || types::is_int($Type);
macro bool is_promotable_to_float($Type) @const => types::is_float($Type) || types::is_int($Type);
macro bool is_promotable_to_floatlike($Type) @const => types::is_floatlike($Type) ||| types::is_int($Type);
macro bool is_promotable_to_float($Type) @const => types::is_float($Type) ||| types::is_int($Type);
macro bool is_same_vector_type($Type1, $Type2) @const
{
@@ -345,7 +345,7 @@ macro bool has_equals($Type) @const => $defined(($Type){} == ($Type){});
macro bool is_equatable_type($Type) @const
{
$if $defined($Type.less) || $defined($Type.compare_to) || $defined($Type.equals):
$if $defined($Type.less) ||| $defined($Type.compare_to) ||| $defined($Type.equals):
return true;
$else
return $Type.is_eq;
@@ -357,7 +357,7 @@ macro bool is_equatable_type($Type) @const
*>
macro bool implements_copy($Type) @const
{
return $defined($Type.copy) && $defined($Type.free);
return $defined($Type.copy) &&& $defined($Type.free);
}
macro bool @equatable_value(#value) @const
@@ -367,7 +367,7 @@ macro bool @equatable_value(#value) @const
macro bool @comparable_value(#value) @const
{
$if $defined(#value.less) || $defined(#value.compare_to):
$if $defined(#value.less) ||| $defined(#value.compare_to):
return true;
$else
return $typeof(#value).is_ordered;

9
src/compiler/sema_expr.c
View File

@@ -5106,7 +5106,8 @@ static inline bool sema_expr_analyse_type_access(SemaContext *context, Expr *exp
{
if (decl->unit->module->stage < ANALYSIS_POST_REGISTER)
{
SEMA_WARN(expr, "There might be a method '%s' for %s, but methods for the type have not yet been completely registered, so a warning is issued.", name, type_quoted_error_string(parent_type));
bool err = SEMA_WARN_STRICT(expr, "There might be a method '%s' for %s, but methods for the type have not yet been completely registered, so a warning is issued.", name, type_quoted_error_string(parent_type));
if (err) return false;
}
goto MISSING_REF;
}
@@ -5595,7 +5596,8 @@ CONTINUE:
Decl *decl = type->decl;
if (!decl->unit || decl->unit->module->stage < ANALYSIS_POST_REGISTER)
{
SEMA_WARN(expr, "Methods are not fully determined for %s at this point.", decl->name);
bool err = SEMA_WARN(expr, "Methods are not fully determined for %s at this point.", decl->name);
if (err) return false;
}
// Interface, prefer interface methods.
if (decl->decl_kind == DECL_INTERFACE)
@@ -6627,7 +6629,8 @@ CHECK_DEEPER:
ASSERT(type_is_user_defined(parent_type));
if (missing_ref && parent_type->decl->unit->module->stage < ANALYSIS_POST_REGISTER)
{
SEMA_WARN(expr, "There might be a method '%s' for %s, but methods have not yet been completely registered, so analysis fails.", kw, type_quoted_error_string(parent->type));
bool err = SEMA_WARN_STRICT(expr, "There might be a method '%s' for %s, but methods have not yet been completely registered, so analysis fails.", kw, type_quoted_error_string(parent->type));
if (err) return false;
}
if (parent_type->type_kind == TYPE_INTERFACE)
{

2
src/compiler/sema_internal.h
View File

@@ -18,6 +18,7 @@
#define UINT20_MAX 1048575U
#define SEMA_WARN(_node, ...) (sema_warn_at(context, (_node)->span, __VA_ARGS__))
#define SEMA_WARN_STRICT(_node, ...) (sema_warn_very_strict(context, (_node)->span, __VA_ARGS__))
#define SEMA_ERROR(_node, ...) sema_error_at(context, (_node)->span, __VA_ARGS__)
#define RETURN_SEMA_ERROR(_node, ...) do { sema_error_at(context, (_node)->span, __VA_ARGS__); return false; } while (0)
#define RETURN_VAL_SEMA_ERROR(val__, _node, ...) do { sema_error_at(context, (_node)->span, __VA_ARGS__); return (val__); } while (0)
@@ -59,6 +60,7 @@ TokenType sema_splitpathref(const char *string, ArraySize len, Path **path_ref,
void sema_print_inline(SemaContext *context, SourceSpan span_original);
void sema_error_at(SemaContext *context, SourceSpan span, const char *message, ...);
bool sema_warn_at(SemaContext *context, SourceSpan span, const char *message, ...);
bool sema_warn_very_strict(SemaContext *context, SourceSpan span, const char *message, ...);
void sema_context_init(SemaContext *context, CompilationUnit *unit);
void sema_context_destroy(SemaContext *context);

11
src/compiler/semantic_analyser.c
View File

@@ -609,6 +609,17 @@ void sema_error_at(SemaContext *context, SourceSpan span, const char *message, .
sema_print_inline(context, span);
}
bool sema_warn_very_strict(SemaContext *context, SourceSpan span, const char *message, ...)
{
if (compiler.build.validation_level < VALIDATION_OBNOXIOUS) return false;
va_list list;
va_start(list, message);
sema_verror_range(span, message, list);
va_end(list);
sema_print_inline(context, span);
return true;
}
bool sema_warn_at(SemaContext *context, SourceSpan span, const char *message, ...)
{
bool is_warn = compiler.build.validation_level < VALIDATION_STRICT;