shishantbiswas/c3c
1
1
Fork 0
mirror of https://github.com/c3lang/c3c.git synced 2026-02-27 12:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better checks for missing @dynamic. Addresses #1055.

Browse Source
This commit is contained in:
Christoffer Lerno
2023-10-28 04:10:06 +02:00
parent e17bb5f321
commit e4c1328ef2
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/std/core/allocators/temp_allocator.c3
View File

@@ -45,7 +45,7 @@ fn TempAllocator*! new_temp(usz size, Allocator* using)
return allocator;
}
fn usz TempAllocator.mark(&self) => self.used;
fn usz TempAllocator.mark(&self) @dynamic => self.used;
fn void TempAllocator.release(&self, void* old_pointer, bool) @dynamic
{

8
src/compiler/sema_passes.c
View File

@@ -612,10 +612,10 @@ static inline bool sema_check_interfaces(Decl *decl)
FOREACH_BEGIN(TypeInfo *interface_type, decl->interfaces)
Decl *interface = interface_type->type->decl;
FOREACH_BEGIN(Decl *method, interface->interface_methods)
if (method->func_decl.attr_optional) continue;
Decl *matching_method = sema_decl_stack_resolve_symbol(method->name);
if (!matching_method)
{
if (method->func_decl.attr_optional) continue;
SEMA_ERROR(interface_type, "'%s' was not fully implemented, required method '%s' needs to be implemented, did you forget it?",
interface->name, method->name);
sema_decl_stack_restore(store);
@@ -623,6 +623,7 @@ static inline bool sema_check_interfaces(Decl *decl)
}
if (matching_method->decl_kind != DECL_FUNC)
{
if (method->func_decl.attr_optional) continue;
SEMA_ERROR(matching_method, "'%s' was not fully implemented, it requires '%s' to be a function marked '@dynamic'.",
interface->name, method->name);
sema_decl_stack_restore(store);
@@ -630,8 +631,9 @@ static inline bool sema_check_interfaces(Decl *decl)
}
if (!matching_method->func_decl.attr_dynamic)
{
SEMA_ERROR(matching_method, "'%s' was not fully implemented, you need to mark '%s' as '@dynamic'.",
interface->name, method->name);
SEMA_ERROR(matching_method, "'%s(...)' must be marked '@dynamic' as it matches the method '%s' in interface '%s'.",
method->name, method->name, interface->name);
SEMA_NOTE(method, "Here is the interface method to implement.");
sema_decl_stack_restore(store);
return false;
}

2
src/version.h
View File

@@ -1 +1 @@
#define COMPILER_VERSION "0.4.690"
#define COMPILER_VERSION "0.4.691"