shishantbiswas/c3c
1
1
Fork 0
mirror of https://github.com/c3lang/c3c.git synced 2026-02-27 12:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor change in checking for unclear precedence

Browse Source 
Previously the function which is now named "unclear_op_precedence()" used to have an extra not operator when an unclear precedence was found, and then there was also a not operator in the if statement checking for unclear precedence. This was harder to read and having two not operators after each other is totally redundant.
This commit is contained in:
mathis2003
2021-04-17 00:29:32 +02:00
committed by Christoffer Lerno
parent 5a7c174aa5
commit ee307f2dba
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/compiler/parse_expr.c
View File

@@ -393,20 +393,20 @@ static Expr *parse_failable(Context *context, Expr *left_side)
}
bool plain_op_precedence(Expr *left_side, Expr * main_expr, Expr *right_side)
bool unclear_op_precedence(Expr *left_side, Expr * main_expr, Expr *right_side)
{
int precedence_main = BINOP_PREC_REQ[main_expr->binary_expr.operator];
if (left_side->expr_kind == EXPR_BINARY)
{
int precedence_left = BINOP_PREC_REQ[left_side->binary_expr.operator];
return !(precedence_left && (precedence_left == precedence_main));
return precedence_left && (precedence_left == precedence_main);
}
if (right_side->expr_kind == EXPR_BINARY)
{
int precedence_right = BINOP_PREC_REQ[right_side->binary_expr.operator];
return !(precedence_right && (precedence_right == precedence_main));
return precedence_right && (precedence_right == precedence_main);
}
return true;
return false;
}
static Expr *parse_binary(Context *context, Expr *left_side)
@@ -434,7 +434,7 @@ static Expr *parse_binary(Context *context, Expr *left_side)
expr->binary_expr.right = right_side;
// check if both sides have a binary operation where the precedence is unclear. Example: a ^ b | c
if (!plain_op_precedence(left_side, expr, right_side))
if (unclear_op_precedence(left_side, expr, right_side))
{
SEMA_TOKEN_ERROR(context->tok, "You need to add explicit parentheses.");
}